New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch from glob to readdirp #19

Merged
merged 1 commit into from Sep 30, 2013

Conversation

Projects
None yet
3 participants
@gotdibbs
Contributor

gotdibbs commented Sep 24, 2013

Resolves an issue with glob/minimatch where UNC paths are not
interpreted correctly. Using readdirp instead allows us to use a more
robust, simplified and asynchronous approach to loading the partials.

Switch from glob to readdirp
Works around an issue with `glob`/`minimatch` where UNC paths are not
interpreted correctly. Using `readdirp` instead allows us to use a more
robust, simplified and asynchronous approach to loading the partials.
@mgutz

This comment has been minimized.

Show comment
Hide comment
@mgutz

mgutz Sep 24, 2013

Thanks, will look at this thoroughly in the next couple of days. We use glob,minimatch in other projects.

mgutz commented Sep 24, 2013

Thanks, will look at this thoroughly in the next couple of days. We use glob,minimatch in other projects.

@gotdibbs

This comment has been minimized.

Show comment
Hide comment
@gotdibbs

gotdibbs Sep 24, 2013

Contributor

@mgutz Thanks, let me know if I can provide more background or any sample code/scenarios. We discovered this on Ghost when trying to run on Azure where all files are stored on a UNC path.

Contributor

gotdibbs commented Sep 24, 2013

@mgutz Thanks, let me know if I can provide more background or any sample code/scenarios. We discovered this on Ghost when trying to run on Azure where all files are stored on a UNC path.

@ErisDS

This comment has been minimized.

Show comment
Hide comment
@ErisDS

ErisDS Sep 29, 2013

Contributor

We're pushing express-hbs pretty hard with Ghost. Not only is Ghost being installed on lots of different environments & setups, but we also have the ability to switch theme - that is switch the folder from which views are served - whilst the application is running.

Thus we are turning up some pretty interesting use cases :)

Contributor

ErisDS commented Sep 29, 2013

We're pushing express-hbs pretty hard with Ghost. Not only is Ghost being installed on lots of different environments & setups, but we also have the ability to switch theme - that is switch the folder from which views are served - whilst the application is running.

Thus we are turning up some pretty interesting use cases :)

mgutz pushed a commit that referenced this pull request Sep 30, 2013

Mario Gutierrez
Merge pull request #19 from gotdibbs/readdirp
Switch from glob to readdirp

@mgutz mgutz merged commit 2b0e370 into barc:master Sep 30, 2013

@gotdibbs gotdibbs deleted the gotdibbs:readdirp branch Sep 30, 2013

@gotdibbs

This comment has been minimized.

Show comment
Hide comment
@gotdibbs

gotdibbs Sep 30, 2013

Contributor

@mgutz Awesome, thanks for this. Keep up the good work!

Contributor

gotdibbs commented Sep 30, 2013

@mgutz Awesome, thanks for this. Keep up the good work!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment