New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed issue with partials not loading #24

Merged
merged 1 commit into from Oct 24, 2013

Conversation

Projects
None yet
5 participants
@gotdibbs
Contributor

gotdibbs commented Oct 18, 2013

Resolves an issue where partials are not loaded correctly in the event
the options.cache is set to true. Accordingly allows partials to be
loaded once, or loaded every time if caching is disabled.

In order to test both situations where caching may be on or off, we
toggle the process.env.NODE_ENV variable which in effect toggles the
options.cache parameter. Thus I have included grunt to run the same
test suite twice; once as the test suite was run before, and then again
with the environment variable set to production.

Fixed issue with partials not loading
Resolves an issue where partials are not loaded correctly in the event
the `options.cache` is set to `true`. Accordingly allows partials to be
loaded once, or loaded every time if caching is disabled.

In order to test both situations where caching may be on or off, we
toggle the `process.env.NODE_ENV` variable which in effect toggles the
`options.cache` parameter. Thus I have included grunt to run the same
test suite twice; once as the test suite was run before, and then again
with the environment variable set to production.
@williamcoates

This comment has been minimized.

Show comment
Hide comment
@williamcoates

williamcoates Oct 18, 2013

Contributor

+1

Contributor

williamcoates commented Oct 18, 2013

+1

@shanselman

This comment has been minimized.

Show comment
Hide comment
@shanselman

shanselman commented Oct 23, 2013

+1 Around?

@ErisDS

This comment has been minimized.

Show comment
Hide comment
@ErisDS

ErisDS Oct 24, 2013

Contributor

@mgutz Any chance we could get this merged?

Contributor

ErisDS commented Oct 24, 2013

@mgutz Any chance we could get this merged?

@mgutz

This comment has been minimized.

Show comment
Hide comment
@mgutz

mgutz Oct 24, 2013

Yes, will look at it today. Just got back from R&R :)

mgutz commented Oct 24, 2013

Yes, will look at it today. Just got back from R&R :)

@ErisDS

This comment has been minimized.

Show comment
Hide comment
@ErisDS

ErisDS Oct 24, 2013

Contributor

Fantastic, hope you enjoyed yourself? The project @gotdibbs and I are working on, Ghost is now public and we're trying to iron out some issues our users are experiencing, as well as make it possible to run on Windows Azure

Contributor

ErisDS commented Oct 24, 2013

Fantastic, hope you enjoyed yourself? The project @gotdibbs and I are working on, Ghost is now public and we're trying to iron out some issues our users are experiencing, as well as make it possible to run on Windows Azure

@mgutz mgutz merged commit 2048e3f into barc:master Oct 24, 2013

@gotdibbs gotdibbs deleted the gotdibbs:partials-fix branch Oct 24, 2013

@gotdibbs

This comment has been minimized.

Show comment
Hide comment
@gotdibbs

gotdibbs Oct 24, 2013

Contributor

Thanks @mgutz !!

Contributor

gotdibbs commented Oct 24, 2013

Thanks @mgutz !!

@shanselman

This comment has been minimized.

Show comment
Hide comment
@shanselman

shanselman Oct 24, 2013

Awesome. Thank you!

On Oct 24, 2013, at 12:00 PM, William Dibbern notifications@github.com wrote:

Thanks @mgutz !!


Reply to this email directly or view it on GitHub.

shanselman commented Oct 24, 2013

Awesome. Thank you!

On Oct 24, 2013, at 12:00 PM, William Dibbern notifications@github.com wrote:

Thanks @mgutz !!


Reply to this email directly or view it on GitHub.

@ErisDS

This comment has been minimized.

Show comment
Hide comment
@ErisDS

ErisDS Oct 24, 2013

Contributor

🍰 woop woop! Thanks 👍

Contributor

ErisDS commented Oct 24, 2013

🍰 woop woop! Thanks 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment