New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Accept both 'char' and 'misc' as names for the charset #12

Merged
merged 1 commit into from Apr 18, 2018

Conversation

Projects
None yet
2 participants
@jjatria
Contributor

jjatria commented Mar 9, 2018

This patch addresses the issue in #11. It documents the existence of 'misc' as a key, and accepts 'char' to implement the documented behaviour.

This solution means that documented behaviour does not need to change, and any code that might currently be using the undocumented behaviour should continue to work as expected.

Accept both 'char' and 'misc' as names for the charset
The documentation for rand_chars() stated that there was a
character set with the name 'char'. However, the code actually
expected the name 'misc', which was not documented.

This patch documents the existence of 'misc' as a key, and accepts
'char' to implement the documented behaviour.

@barefootcoder barefootcoder merged commit e188bfb into barefootcoder:master Apr 18, 2018

@jjatria jjatria deleted the jjatria:charset-name branch Apr 22, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment