Accept both 'char' and 'misc' as names for the charset #12
Conversation
The documentation for rand_chars() stated that there was a character set with the name 'char'. However, the code actually expected the name 'misc', which was not documented. This patch documents the existence of 'misc' as a key, and accepts 'char' to implement the documented behaviour.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
This patch addresses the issue in #11. It documents the existence of 'misc' as a key, and accepts 'char' to implement the documented behaviour.
This solution means that documented behaviour does not need to change, and any code that might currently be using the undocumented behaviour should continue to work as expected.