Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.
Sign upAccept both 'char' and 'misc' as names for the charset #12
Conversation
barefootcoder
merged commit e188bfb
into
barefootcoder:master
Apr 18, 2018
barefootcoder
referenced this pull request
Apr 18, 2018
Closed
Documented 'chars' character set is actually named 'misc' #11
added a commit
that referenced
this pull request
Apr 18, 2018
jjatria
deleted the
jjatria:charset-name
branch
Apr 22, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
jjatria commentedMar 9, 2018
This patch addresses the issue in #11. It documents the existence of 'misc' as a key, and accepts 'char' to implement the documented behaviour.
This solution means that documented behaviour does not need to change, and any code that might currently be using the undocumented behaviour should continue to work as expected.