Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use Test::MockTime to stop the passage of time in tests #8

Merged
merged 1 commit into from Jan 25, 2018

Conversation

@jjatria
Copy link
Contributor

@jjatria jjatria commented Jan 21, 2018

Use Test::MockTime to make the time stand still while testing time related functions. In particular, this solves the (unlikely) issue with 'now' tests in t/rand_time.t.

This is part of the pull request challenge.

@barefootcoder
Copy link
Owner

@barefootcoder barefootcoder commented Jan 24, 2018

Okay, now that I've merged the dzil stuff, this PR needs a minor touch-up. If you can take care of that, I should be able to merge this in later this week.

Thx for all your hard work!

@jjatria
Copy link
Contributor Author

@jjatria jjatria commented Jan 24, 2018

No worries! I'll rebase this and fix the conflicts later today.

I was thinking also of trying to bring the test coverage up a bit. I'll open up another ticket to discuss.

@jjatria jjatria force-pushed the jjatria:mocktime branch from 664180b to 86cb482 Jan 24, 2018
@jjatria
Copy link
Contributor Author

@jjatria jjatria commented Jan 24, 2018

I've rebased the branch off of master 👍

@barefootcoder barefootcoder merged commit 3777b88 into barefootcoder:master Jan 25, 2018
barefootcoder added a commit that referenced this pull request Jan 25, 2018
@jjatria jjatria deleted the jjatria:mocktime branch Apr 22, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants