Skip to content
This repository has been archived by the owner on Apr 13, 2022. It is now read-only.

Double Date Range error when date range is same day #8

Closed
dja opened this issue Jul 7, 2015 · 1 comment
Closed

Double Date Range error when date range is same day #8

dja opened this issue Jul 7, 2015 · 1 comment

Comments

@dja
Copy link

dja commented Jul 7, 2015

Looks like the start date and end date are compared based on their html text value, which is formatted as Month Day, Year. It would be beneficial if it were based on actual Moment(), whether in unix or date. The main reason is that it causes complications when the start date and end date are both the same day (but may want that to be hours/min etc).

@kalepail
Copy link
Contributor

I actually do do a date comparison off the html values.. so the html values are converted into a date object. Anything beyond just days though is beyond the scope of this particular date range but if you'd like to add hour/min functionality I'd be glad to at least make it a separate branch if no include it into the main branch.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants