Fix dbcheck orphaned path entries performance issue

A previous commit introduced performance issues when using the
bareos-dbcheck orphaned path detection. The underlying SQL query
was changed now by using the PathHierarchy table for protecting
Path entries used by BVFS.

src/cats/dml/0072_get_orphaned_paths_0

@@ -1,13 +1,12 @@
 #
 # dbcheck: eliminate_orphaned_path_records
 #
-# get all Paths not used by Files
-# and are not substrings to others Paths.
+# get all Paths not used by Files or BVFS
 #
-# LIKE: _% wildcard, but at least one character
-#
-SELECT DISTINCT ParentPath.PathId,File.PathId,ParentPath.Path
-FROM Path AS ParentPath LEFT OUTER JOIN File USING(PathId)
+SELECT DISTINCT Path.PathId, File.PathId, Path.Path
+FROM Path
+LEFT JOIN File USING (PathId)
+LEFT JOIN PathHierarchy ON (Path.Pathid = PathHierarchy.PPathId)
 WHERE File.PathId IS NULL
-  AND NOT EXISTS (SELECT 1 FROM Path WHERE Path LIKE ParentPath.Path || '_%%')
+  AND PathHierarchy.PPathId IS NULL
 LIMIT 300000

src/cats/mysql_queries.inc

@@ -873,11 +873,13 @@ const char *B_DB_MYSQL::query_definitions[] = {
 "WHERE Log.JobId=%s "
 ,
 
-/* 0072_get_orphaned_paths_0.mysql */
-"SELECT DISTINCT ParentPath.PathId,File.PathId,ParentPath.Path "
-"FROM Path AS ParentPath LEFT OUTER JOIN File USING(PathId) "
+/* 0072_get_orphaned_paths_0 */
+"SELECT DISTINCT Path.PathId, File.PathId, Path.Path "
+"FROM Path "
+"LEFT JOIN File USING (PathId) "
+"LEFT JOIN PathHierarchy ON (Path.Pathid = PathHierarchy.PPathId) "
 "WHERE File.PathId IS NULL "
-  "AND NOT EXISTS (SELECT 1 FROM Path WHERE Path LIKE CONCAT(ParentPath.Path,'_%%')) "
+  "AND PathHierarchy.PPathId IS NULL "
 "LIMIT 300000 "
 ,
 

src/cats/postgresql_queries.inc

@@ -849,10 +849,12 @@ const char *B_DB_POSTGRESQL::query_definitions[] = {
 ,
 
 /* 0072_get_orphaned_paths_0 */
-"SELECT DISTINCT ParentPath.PathId,File.PathId,ParentPath.Path "
-"FROM Path AS ParentPath LEFT OUTER JOIN File USING(PathId) "
+"SELECT DISTINCT Path.PathId, File.PathId, Path.Path "
+"FROM Path "
+"LEFT JOIN File USING (PathId) "
+"LEFT JOIN PathHierarchy ON (Path.Pathid = PathHierarchy.PPathId) "
 "WHERE File.PathId IS NULL "
-  "AND NOT EXISTS (SELECT 1 FROM Path WHERE Path LIKE ParentPath.Path || '_%%') "
+  "AND PathHierarchy.PPathId IS NULL "
 "LIMIT 300000 "
 ,
 

src/cats/sqlite_queries.inc

@@ -859,10 +859,12 @@ const char *B_DB_SQLITE::query_definitions[] = {
 ,
 
 /* 0072_get_orphaned_paths_0 */
-"SELECT DISTINCT ParentPath.PathId,File.PathId,ParentPath.Path "
-"FROM Path AS ParentPath LEFT OUTER JOIN File USING(PathId) "
+"SELECT DISTINCT Path.PathId, File.PathId, Path.Path "
+"FROM Path "
+"LEFT JOIN File USING (PathId) "
+"LEFT JOIN PathHierarchy ON (Path.Pathid = PathHierarchy.PPathId) "
 "WHERE File.PathId IS NULL "
-  "AND NOT EXISTS (SELECT 1 FROM Path WHERE Path LIKE ParentPath.Path || '_%%') "
+  "AND PathHierarchy.PPathId IS NULL "
 "LIMIT 300000 "
 ,