Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

webui: update jquery from v3.2.0 to v3.6.0 #1084

Merged
merged 2 commits into from Mar 3, 2022
Merged

webui: update jquery from v3.2.0 to v3.6.0 #1084

merged 2 commits into from Mar 3, 2022

Conversation

fbergkemper
Copy link
Contributor

@fbergkemper fbergkemper commented Feb 24, 2022

Backport of PR #1083 to bareos-21

Fixes #1430: Version of Jquery is old and vulnerable

(cherry picked from commit cbbe75e)

Thank you for contributing to the Bareos Project!

Please check

  • Short description and the purpose of this PR is present above this paragraph
  • Your name is present in the AUTHORS file (optional)

If you have any questions or problems, please give a comment in the PR.

Helpful documentation and best practices

Checklist for the reviewer of the PR (will be processed by the Bareos team)

General
  • PR name is meaningful
  • Purpose of the PR is understood
  • Separate commit for this PR in the CHANGELOG.md, PR number referenced is same
  • Commit descriptions are understandable and well formatted
  • If backport: add original PR number and target branch at top of this file: Backport of PR#000 to bareos-2x
Source code quality
  • Source code changes are understandable
  • Variable and function names are meaningful
  • Code comments are correct (logically and spelling)
  • Required documentation changes are present and part of the PR
  • bareos-check-sources --since-merge does not report any problems
  • git status should not report modifications in the source tree after building and testing

Fixes #1430: Version of Jquery is old and vulnerable

(cherry picked from commit cbbe75e)
Copy link
Contributor

@bruno-at-bareos bruno-at-bareos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please check changes requested

CHANGELOG.md Show resolved Hide resolved
@bruno-at-bareos bruno-at-bareos self-requested a review March 2, 2022 09:18
Copy link
Contributor

@bruno-at-bareos bruno-at-bareos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed and adjusted, ready for a merge

@bruno-at-bareos
Copy link
Contributor

@pstorz ok for merge

@fbergkemper
Copy link
Contributor Author

Reviewed and adjusted, ready for a merge

As discussed in another place, backports are no longer explicitly marked in CHANGELOG.md. We should edit our GitHub PR template to not get trapped.

@pstorz pstorz merged commit 76b0bfb into bareos:bareos-21 Mar 3, 2022
@fbergkemper fbergkemper deleted the dev/fbergkemper/bareos-21/jquery-update branch March 10, 2022 15:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants