dird: fix tls reload crash

[pstorz]

The director reload logic was not aware of the fact that the tls-psk mechanism's callback also accesses the configuration resources.

The tls_openssl_private objects now also have a shared_ptr to the configuration resources to make sure that these are not freed between the tls-psk callback is setup and the callback is really called.

The following patch can be used to trigger the problem when built with sanitizers:

diff --git a/core/src/lib/tls_openssl_private.cc b/core/src/lib/tls_openssl_private.cc
index 3b47510a2..ece45fa6e 100644
--- a/core/src/lib/tls_openssl_private.cc
+++ b/core/src/lib/tls_openssl_private.cc
@@ -468,7 +468,7 @@ unsigned int TlsOpenSslPrivate::psk_server_cb(SSL* ssl,
   Dmsg1(100, "psk_server_cb. identitiy: %s.\n", lst.JoinReadable().c_str());
 
   std::string configured_psk;
-
+  Bmicrosleep(5, 0);
   ConfigurationParser* config
       = static_cast<ConfigurationParser*>(SSL_CTX_get_ex_data(
           openssl_ctx,

• Reload the config every second e.g. with
  kill -HUP $(pidof bareos_dir-reload)
• start bconsole

Please check

• Short description and the purpose of this PR is present above this paragraph
• Your name is present in the AUTHORS file (optional)

If you have any questions or problems, please give a comment in the PR.

Helpful documentation and best practices

• Git Workflow
• Automatic Sourcecode Formatting
• Check your commit messages

Checklist for the reviewer of the PR (will be processed by the Bareos team)

General

• PR name is meaningful
• Purpose of the PR is understood
• Separate commit for this PR in the CHANGELOG.md, PR number referenced is same
• Commit descriptions are understandable and well formatted

Source code quality

• Source code changes are understandable
• Variable and function names are meaningful
• Code comments are correct (logically and spelling)
• Required documentation changes are present and part of the PR
• bareos-check-sources --since-merge does not report any problems
• git status should not report modifications in the source tree after building and testing

[arogge]

Looks pretty good, I just have some stylistic comments.