Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

core and webui: adapt binary info messages to new wording #1298

Merged
merged 3 commits into from Nov 2, 2022

Conversation

joergsteffens
Copy link
Member

@joergsteffens joergsteffens commented Oct 28, 2022

The Bareos project will extend its publishing policy soon. Alongside with this, it also changes the wording about naming the releases a bit. This PR contains the new working for self-compiled binaries.

  • Short description and the purpose of this PR is present above this paragraph
  • Your name is present in the AUTHORS file (optional)

If you have any questions or problems, please give a comment in the PR.

Helpful documentation and best practices

Checklist for the reviewer of the PR (will be processed by the Bareos team)

General
  • PR name is meaningful
  • Purpose of the PR is understood
  • Commit descriptions are understandable and well formatted
  • Check backport line
  • Is the PR title usable as CHANGELOG entry?
  • Separate commit for CHANGELOG.md ("update CHANGELOG.md"). The PR number is correct.
Source code quality
  • Source code changes are understandable
  • Variable and function names are meaningful
  • Code comments are correct (logically and spelling)
  • Required documentation changes are present and part of the PR
  • bareos-check-sources --since-merge does not report any problems

Be default, self-compiled binaries contain the message:

Self-compiled binaries (UNSUPPORTED)\n
Get professional support from https://www.bareos.com
When login with bconsole, the director starts with displaying information about its binary status
(self-compiled, ...). Until now, it shows BAREOS_BINARY_INFO and BAREOS_SERVICES_MESSAGE.
However, BAREOS_BINARY_INFO is more or less the short form of BAREOS_SERVICES_MESSAGE,
so we reduced it to display only BAREOS_SERVICES_MESSAGE.
@joergsteffens joergsteffens marked this pull request as ready for review October 30, 2022 10:36
@pstorz pstorz changed the title Adapt Bareos messages to new wording. core and webui: adapt Bareos messages to new wording Oct 31, 2022
@pstorz pstorz changed the title core and webui: adapt Bareos messages to new wording core and webui: adapt binary info messages to new wording Oct 31, 2022
Copy link
Member

@pstorz pstorz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good.

@pstorz pstorz merged commit ff39524 into bareos:master Nov 2, 2022
@joergsteffens joergsteffens deleted the dev/joergs/master/community branch October 11, 2023 08:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants