Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backport to 18.2: Fix bogus errors in TLS sessions #232 #234

Merged
merged 1 commit into from Aug 1, 2019

Conversation

@arogge
Copy link
Contributor

commented Jul 19, 2019

If during or before SSL_shutdown() errors occured that were saved in the
thread-local openssl error queue, these were not read and thus retained
on the queue until another tls session read them.
This lead to bogus error detection. Now we simply clear all errors from
the queue after we're done with our openssl context, so the errors do
not "leak" into another context anymore.

(cherry picked from commit cf3e106)

core: empty openssl error queue on SSL_shutdown()
If during or before SSL_shutdown() errors occured that were saved in the
thread-local openssl error queue, these were not read and thus retained
on the queue until another tls session read them.
This lead to bogus error detection. Now we simply clear all errors from
the queue after we're done with our openssl context, so the errors do
not "leak" into another context anymore.

(cherry picked from commit cf3e106)

@arogge arogge requested a review from franku Jul 19, 2019

@franku

This comment has been minimized.

Copy link
Member

commented Jul 19, 2019

Successful on my local buildsystem on a Fedora 29.

@arogge arogge merged commit 3102a46 into bareos-18.2 Aug 1, 2019

3 of 4 checks passed

continuous-integration/jenkins/branch This commit cannot be built
Details
continuous-integration/jenkins/pr-merge This commit looks good
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

@arogge arogge deleted the dev/arogge/bareos-18.2/TT4200514 branch Aug 30, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.