Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.Sign up
Enhancements to python-bareos #314
Enhancements to python-bareos:
franku left a comment
Wow, lot of work. I mentioned some things about tls-require and tls-enable. Many of the function names could be chosen to better reflect their purpose, rather than writing comments that describe what they do.
I did code review, not ran any tests.
Also: * Implement PAM authentication. * Reduce warnings by closing socket, when they are no longer required. * Prepare python-bareos version number. Fallback to 18.2.5, as this is the first version that uses the new protocol. * Handle end of data in interactive mode. * Adapted for connections to the Filedaemon.
The Director Console Protocol >= 18.2.4 offers a lot more connection parameters. Add util functions to the classes to help providing the same set of parameters to all command line tools. Allow password as string parameter. It will be converted to Bareos.Util.Password during initialization. Also added a fallback to old Director Console protocol (12.4), if authentication to Director fails. If protocolversion is set exclipietly, there will be no automatic fallback.
…versions (18.2 and 12.4) Make usage of TLS-PSK optional in most cases. This is necessary to successfully run the test without the python module sslpsk. Add Filedaemon connection tests. Added test for client ACLs at the restore command.