Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cmake: Use date command on cmake <3.10 so %B works #393

Merged
merged 1 commit into from Jan 13, 2020

Conversation

arogge
Copy link
Member

@arogge arogge commented Jan 13, 2020

Previously cmake fell back on using the date command in favour of
TIMESTAMP when the cmake version was 3.8 or older. This lead to a case
where a literal %B was added in the Bareos date when building with
cmake 3.8 to 3.10.
This patch makes cmake fall back to use the date command on versions up
to 3.10.

@arogge arogge requested a review from pstorz January 13, 2020 13:37
Copy link
Member

@pstorz pstorz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested on centos7 with cmake 3.9.4: now works as expected.

Previously cmake fell back on using the date command in favour of
TIMESTAMP when the cmake version was 3.8 or older. This lead to a case
where a literal %B was added in the Bareos date when building with
cmake 3.8 to 3.10.
This patch makes cmake fall back to use the date command on versions up
to 3.10.
@arogge arogge force-pushed the dev/arogge/master/fix-cmake-timestamp branch from 86bfca7 to ffa0d4f Compare January 13, 2020 14:03
@arogge arogge merged commit 6e54535 into bareos:master Jan 13, 2020
@arogge arogge deleted the dev/arogge/master/fix-cmake-timestamp branch August 10, 2020 08:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants