Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

webui: fix possible issues due to PAM misconfiguration #936

Merged
merged 2 commits into from Sep 29, 2021

Conversation

fbergkemper
Copy link
Contributor

@fbergkemper fbergkemper commented Sep 27, 2021

Check if UsePAMAuthentication is enabled on configured console
in DIR, if not do not proceed with authentication.

Fixes #1191: The web interface runs under any login and password

Thank you for contributing to the Bareos Project!

Please check

  • Short description and the purpose of this PR is present above this paragraph
  • Your name is present in the AUTHORS file (optional)

If you have any questions or problems, please give a comment in the PR.

Helpful documentation and best practices

Checklist for the reviewer of the PR (will be processed by the Bareos team)

General
  • PR name is meaningful
  • Purpose of the PR is understood
  • Separate commit for this PR in the CHANGELOG.md, PR number referenced is same
  • Commit descriptions are understandable and well formatted
Source code quality
  • Source code changes are understandable
  • Variable and function names are meaningful
  • Code comments are correct (logically and spelling)
  • Required documentation changes are present and part of the PR
  • bareos-check-sources --since-merge does not report any problems
  • git status should not report modifications in the source tree after building and testing

@fbergkemper fbergkemper self-assigned this Sep 27, 2021
@fbergkemper fbergkemper force-pushed the dev/fbergkemper/master/bug-1191 branch 4 times, most recently from f7b8ce6 to fafe231 Compare September 28, 2021 14:30
Copy link
Member

@joergsteffens joergsteffens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I added an error message for a specific case and tried to clarify the example configuration. Besides of this, I fully agree with this change.
Feel free to stash my commit into yours.

Check if UsePAMAuthentication is enabled on configured console
in DIR, if not do not proceed with authentication.

Fixes #1191: The web interface runs under any login and password
@fbergkemper
Copy link
Contributor Author

Thanks for the additions and the review.

@fbergkemper fbergkemper merged commit b716373 into master Sep 29, 2021
@fbergkemper fbergkemper deleted the dev/fbergkemper/master/bug-1191 branch March 9, 2022 16:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants