Merge pull request ViennaRSS#1006 from barijaona/issue-1005

Fix tests on keys in KVO patterns
barijaona · Sep 14, 2017 · 572693c · 572693c
2 parents ca7d7c6 + 245caf7
commit 572693c
Show file tree

Hide file tree

Showing 4 changed files with 4 additions and 4 deletions.
diff --git a/src/ArticleController.m b/src/ArticleController.m
@@ -1096,7 +1096,7 @@ - (void)observeValueForKeyPath:(NSString *)keyPath
                       ofObject:(id)object
                         change:(NSDictionary<NSKeyValueChangeKey,id> *)change
                        context:(void *)context {
-    if (keyPath == MAPref_FilterMode) {
+    if ([keyPath isEqualToString:MAPref_FilterMode]) {
         // Update the list of articles when the user changes the filter.
         @synchronized(mainArticleView) {
             [mainArticleView refreshFolder:MA_Refresh_ReapplyFilter];

diff --git a/src/ArticleListView.m b/src/ArticleListView.m
@@ -1732,7 +1732,7 @@ - (void)observeValueForKeyPath:(NSString *)keyPath
                       ofObject:(id)object
                         change:(NSDictionary<NSKeyValueChangeKey,id> *)change
                        context:(void *)context {
-    if (keyPath == MAPref_ShowStatusBar) {
+    if ([keyPath isEqualToString:MAPref_ShowStatusBar]) {
         BOOL isStatusBarShown = [Preferences standardPreferences].showStatusBar;
         if (isStatusBarShown && !self.statusBar) {
             self.statusBar = [OverlayStatusBar new];

diff --git a/src/BrowserPane.m b/src/BrowserPane.m
@@ -791,7 +791,7 @@ - (void)observeValueForKeyPath:(NSString *)keyPath
                       ofObject:(id)object
                         change:(NSDictionary<NSKeyValueChangeKey,id> *)change
                        context:(void *)context {
-    if (keyPath == MAPref_ShowStatusBar) {
+    if ([keyPath isEqualToString:MAPref_ShowStatusBar]) {
         BOOL isStatusBarShown = [Preferences standardPreferences].showStatusBar;
         if (isStatusBarShown && !self.statusBar) {
             self.statusBar = [OverlayStatusBar new];

diff --git a/src/UnifiedDisplayView.m b/src/UnifiedDisplayView.m
@@ -1028,7 +1028,7 @@ - (void)observeValueForKeyPath:(NSString *)keyPath
                       ofObject:(id)object
                         change:(NSDictionary<NSKeyValueChangeKey,id> *)change
                        context:(void *)context {
-    if (keyPath == MAPref_ShowStatusBar) {
+    if ([keyPath isEqualToString:MAPref_ShowStatusBar]) {
         BOOL isStatusBarShown = [Preferences standardPreferences].showStatusBar;
         if (isStatusBarShown && !self.statusBar) {
             self.statusBar = [OverlayStatusBar new];