Skip to content

Baris Balic
barisbalic

Organizations

@nko2 @nko3 @lnug @tableflip @24pullrequests
May 24, 2016
@barisbalic

Wow. This is slick. Thanks for the instant response.

May 24, 2016
@barisbalic
Request: Specify root element when parsing JSON
May 23, 2016
barisbalic commented on pull request swoosh/swoosh#80
@barisbalic

Hey all! I think with regards to the implementation it makes sense for each adapter to house it's own checks. As for raising. I am leaning toward r…

May 15, 2016
barisbalic commented on pull request swoosh/swoosh#79
@barisbalic

👍 Love this too. Agreed on the changelog, also make it clear that by default Memory will "just work", so people don't get put off by the idea of ad…

May 15, 2016
barisbalic commented on pull request swoosh/swoosh#79
@barisbalic

Could be extracted to function, potentially two with one overload just returning children. Not strongly against this though.

May 15, 2016
barisbalic commented on pull request swoosh/swoosh#78
@barisbalic

Love it, depending on how you feel about the comments, get this merged in!

May 15, 2016
barisbalic commented on pull request swoosh/swoosh#78
@barisbalic

Bit messy, but can't think anything nicer. Maybe define the function then pass it into capture_log/1 ?

May 15, 2016
barisbalic commented on pull request swoosh/swoosh#78
@barisbalic

👍

May 15, 2016
barisbalic commented on pull request swoosh/swoosh#78
@barisbalic

Personally dislike the look of this, but understand it's shorter and likely "idiomatic".

May 14, 2016
barisbalic commented on issue swoosh/swoosh#76
@barisbalic

Haha, I think @stevedomin meant. "we" need to make it clearer, not you!

May 11, 2016
barisbalic commented on issue swoosh/swoosh#76
@barisbalic

That is hugely appreciated @monicao

May 11, 2016
barisbalic commented on issue swoosh/swoosh#76
@barisbalic

Hi @monicao thanks for raising this issue. From what you have said, that sounds correct, although from your example I can't see what's wrong and I …

May 3, 2016
barisbalic commented on pull request swoosh/swoosh#74
@barisbalic

👍 on the extraction, documenting my opinion even though we've talked about it :D

Apr 28, 2016
barisbalic commented on pull request swoosh/swoosh#57
@barisbalic

Rebased, because I need to stop putting off things that take a few seconds.

Apr 28, 2016
@barisbalic
Apr 28, 2016
barisbalic commented on pull request swoosh/swoosh#57
@barisbalic

@stevedomin this definitely needs rebasing against master, but I didn't have credentials to run/test Sendgrid or SMTP to hand, could you please run…

Apr 28, 2016
@barisbalic
Apr 28, 2016
barisbalic commented on pull request swoosh/swoosh#73
@barisbalic

I was literally in the process of replying to this! Thanks @nicksanders

Apr 20, 2016
Apr 13, 2016
barisbalic commented on commit swoosh/swoosh@d92c73293c
@barisbalic

Good catch @lau sorry, @stevedomin yeah I was sure of the same but now that it's been pointed out I can't remember how/why.

Apr 10, 2016
barisbalic commented on pull request swoosh/swoosh#62
@barisbalic

Love it 👍

Apr 10, 2016
barisbalic commented on issue swoosh/swoosh#63
@barisbalic

Sorry, sent the email without finishing the reply, it was mentioned in #56 but now that you fixed it, it's 👍

Apr 10, 2016
barisbalic commented on issue swoosh/swoosh#63
@barisbalic

This is mentioned in one of the other issues I created recently On 10 Apr 2016 7:44 pm, "Steve Domin" notifications@github.com wrote: Thanks for r…

Apr 4, 2016
@barisbalic
  • @barisbalic a779e13
    Add basic integration test
Apr 4, 2016
@barisbalic
Apr 4, 2016
barisbalic commented on issue swoosh/swoosh#60
@barisbalic

I wondered the same about sms/mms/push notifications before. I think it's a good idea, but it's definitely very separate to email. I think somethin…

Apr 3, 2016
barisbalic commented on pull request swoosh/swoosh#59
@barisbalic

Okay sounds good to me, still don't like new/1 on it's own, but other than that I agree totally 👍

Apr 3, 2016
barisbalic commented on pull request swoosh/swoosh#59
@barisbalic

I'm certainly onboard with the idea of providing a 'complete' abstraction, and providing a function that takes a map and returns a populated struct…

Mar 31, 2016
barisbalic commented on pull request swoosh/swoosh#58
@barisbalic

👍

Mar 31, 2016
barisbalic commented on pull request swoosh/swoosh#57
@barisbalic

Yeah intended to, just hadn't done yet.

Something went wrong with that request. Please try again.