Got in-reply-to twitter status ID discovery working

barnabywalters · Aug 29, 2013 · d851ca6 · d851ca6
1 parent 76ab853
commit d851ca6
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 6 deletions.
diff --git a/BarnabyWalters/Posse/Helpers.php b/BarnabyWalters/Posse/Helpers.php
@@ -55,16 +55,16 @@ public static function prepareForTwitter($text, $url = null, $inReplyTo = null)
 		if (!empty($inReplyTo)) {
 			if (is_string($inReplyTo))
 				$inReplyTo = [$inReplyTo];
-			elseif (is_array($inReplyTo) and isset($inReplyTo['type']))
-				$inReplyTo = isset($inReplyTo['properties']['syndication'])
-					? $inReplyTo['properties']['syndication']
-					: [$inReplyTo['properties']['url']] ?: [];
+			elseif (is_array($inReplyTo))
+				$inReplyTo = isset($inReplyTo['syndication'])
+					? $inReplyTo['syndication']
+					: @([$inReplyTo['url']] ?: []);
 
 			$tweetPattern = '/https?:\/\/twitter.com\/[a-zA-Z_]{1,20}\/status\/([0-9]*)/';
 
 			foreach ($inReplyTo as $irt):
 				$matches = [];
-				if (preg_match($tweetPattern, $inReplyTo, $matches))
+				if (preg_match($tweetPattern, $irt, $matches))
 					$tweet['in_reply_to_status_id'] = $matches[1];
 					break;
 			endforeach;

diff --git a/tests/BarnabyWalters/Posse/HelpersTest.php b/tests/BarnabyWalters/Posse/HelpersTest.php
@@ -78,7 +78,7 @@ public function testAddsHyphenToBlockquoteSmallPattern() {
 	}
 
 	public function testDerivesInReplyToIdFromObjectInReplyToSyndication() {
-		$result = Helpers::prepareForTwitter('Blah.', 'http://example.com', ['syndication' => ['https://twitter.com/blah/statuses/1234567']]);
+		$result = Helpers::prepareForTwitter('Blah.', 'http://example.com', ['syndication' => ['https://twitter.com/blah/status/1234567']]);
 
 		$this->assertEquals('1234567', $result['in_reply_to_status_id']);
 	}