Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add how to display a caption #300

Closed
1 task done
kelliedesigner opened this issue Aug 24, 2018 · 3 comments
Closed
1 task done

Add how to display a caption #300

kelliedesigner opened this issue Aug 24, 2018 · 3 comments

Comments

@kelliedesigner
Copy link
Contributor

@kelliedesigner kelliedesigner commented Aug 24, 2018

As a user of the Design System
I want to know how to display a caption
So that there's consistency across products

Acceptance Criteria

  • Add how to diaply a caption in the Design System
@kelliedesigner
Copy link
Contributor Author

@kelliedesigner kelliedesigner commented Aug 24, 2018

Website:
screen shot 2018-08-24 at 16 19 47

screen shot 2018-08-24 at 16 19 53

@jeddy3 jeddy3 mentioned this issue Sep 5, 2018
@kelliedesigner
Copy link
Contributor Author

@kelliedesigner kelliedesigner commented Sep 5, 2018

Issues with the current caption include:

  • Relationship between the caption and the image isn't clear
  • The caption looks like a heading for the text below it
  • The bold weight over-emphasises the caption in relation to the main content

@kelliedesigner
Copy link
Contributor Author

@kelliedesigner kelliedesigner commented Sep 5, 2018

Mock-up of solution:
caption-mockup

  • Colour is used to differentiate between caption and paragraph
  • Regular weight allows the image to be the emphasis, and removes confusion of caption appearing to be a heading for text below
  • Vertical line provides a clean flourish which ties in with the future rules on how to display pull quotes #252

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

1 participant