Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add how to display images #396

Closed
kelliedesigner opened this issue Oct 31, 2018 · 3 comments

Comments

3 participants
@kelliedesigner
Copy link
Contributor

commented Oct 31, 2018

As a user of the Design System
I want to know how to display images
So that there is consistency across products

Description

  • Decide on one or more set aspect ratios, and appropriate use of them.

Acceptance Criteria

  • Add how to display images to the Design System
@kelliedesigner

This comment has been minimized.

Copy link
Contributor Author

commented Oct 31, 2018

Current website:
screen shot 2018-10-31 at 09 27 22

screen shot 2018-10-31 at 09 27 38

screen shot 2018-10-31 at 09 28 05

@kelliedesigner

This comment has been minimized.

Copy link
Contributor Author

commented Nov 6, 2018

Guidance draft

Images

  • Only use images if there’s a real need and avoid unnecessary decoration
  • The aspect ratio for images should be 3:2
  • All images must have an alt text
  • include a description of the image in the code to help those who are unable to see it

@kelliedesigner kelliedesigner changed the title How to display images Add guidance on how to display images Dec 13, 2018

@jeddy3 jeddy3 changed the title Add guidance on how to display images Add how to display images Feb 6, 2019

@kelliedesigner kelliedesigner added this to Backlog in Board via automation Feb 21, 2019

@wagg-matt wagg-matt self-assigned this Mar 13, 2019

@jeddy3 jeddy3 moved this from Backlog to To do in Board Mar 13, 2019

@jeddy3 jeddy3 moved this from To do to In progress in Board Mar 13, 2019

@wagg-matt wagg-matt referenced this issue Mar 13, 2019

Merged

Add image #731

Board automation moved this from In progress to Done Mar 13, 2019

@jeddy3

This comment has been minimized.

Copy link
Contributor

commented Apr 12, 2019

From Designing An Aspect Ratio Unit For CSS:

The CSS Working Group have designed an aspect ratio unit for CSS. While this isn’t in browsers yet, this article takes a look at the process of designing a new sizing method and explains how it will work.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.