Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with
or
.
Download ZIP
Browse files

Remove pointless return code from owl_variable_add_defaults

  • Loading branch information...
commit 6a8b5190384f683113444387b65b59ef66bb779f 1 parent 4953c44
@davidben davidben authored
Showing with 4 additions and 5 deletions.
  1. +1 −1  tester.c
  2. +3 −4 variable.c
View
2  tester.c
@@ -338,7 +338,7 @@ int owl_variable_regtest(void) {
char *value;
printf("# BEGIN testing owl_variable\n");
- FAIL_UNLESS("setup", 0==owl_variable_dict_setup(&vd));
+ owl_variable_dict_setup(&vd);
FAIL_UNLESS("get bool var", NULL != (var = owl_variable_get_var(&vd, "rxping")));
FAIL_UNLESS("get bool", 0 == owl_variable_get_bool(var));
View
7 variable.c
@@ -92,7 +92,7 @@ static void owl_variable_dict_newvar_enum_full(owl_vardict *vd,
owl_variable_dict_newvar_enum_full(vd, name, default, summary, description, \
validset, validate, set, get)
-int owl_variable_add_defaults(owl_vardict *vd)
+void owl_variable_add_defaults(owl_vardict *vd)
{
OWLVAR_STRING( "personalbell" /* %OwlVarStub */, "off",
"ring the terminal bell when personal messages are received",
@@ -474,7 +474,6 @@ int owl_variable_add_defaults(owl_vardict *vd)
" personal subscriptions will be entered for the\n"
" user.\n",
NULL, owl_variable_exposure_set, NULL /* use default for get */ );
- return 0;
}
/**************************************************************************/
@@ -595,9 +594,9 @@ int owl_variable_exposure_set(owl_variable *v, const char *newval)
/****************************** GENERAL ***********************************/
/**************************************************************************/
-int owl_variable_dict_setup(owl_vardict *vd) {
+void owl_variable_dict_setup(owl_vardict *vd) {
owl_dict_create(vd);
- return owl_variable_add_defaults(vd);
+ owl_variable_add_defaults(vd);
}
CALLER_OWN GClosure *owl_variable_make_closure(owl_variable *v,
Please sign in to comment.
Something went wrong with that request. Please try again.