New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Villagers disappear on 1.5 #53

Closed
Framartin opened this Issue Mar 13, 2013 · 7 comments

Comments

Projects
None yet
2 participants
@Framartin

With the 1.5 upgrade of Minecraft, villagers on the spawn disappear, so it's impossible to trade. And without a bow, we simply cannot play. The game is blocked.

@Nullreff

This comment has been minimized.

Show comment
Hide comment
@Nullreff

Nullreff Mar 13, 2013

Member

I'll have a a break from work in around 1-2 hours. Will work on fixing it then.

Member

Nullreff commented Mar 13, 2013

I'll have a a break from work in around 1-2 hours. Will work on fixing it then.

@Framartin

This comment has been minimized.

Show comment
Hide comment
@Framartin

Framartin Mar 13, 2013

Whao, you're very quick ! Thanks a lot for all you did :) This is awesome !

Whao, you're very quick ! Thanks a lot for all you did :) This is awesome !

@ghost ghost assigned Nullreff Mar 13, 2013

@Nullreff

This comment has been minimized.

Show comment
Hide comment
@Nullreff

Nullreff Mar 13, 2013

Member

I've reverted dota2.barroncraft.com and dota3.barroncraft.com back to 1.4. It looks like I'm going to have to rebuild the plugin as it has server version checks built in.

Member

Nullreff commented Mar 13, 2013

I've reverted dota2.barroncraft.com and dota3.barroncraft.com back to 1.4. It looks like I'm going to have to rebuild the plugin as it has server version checks built in.

@Nullreff

This comment has been minimized.

Show comment
Hide comment
@Nullreff

Nullreff Mar 13, 2013

Member

After removing the version check from Shopkeepers, it's still crashing. It's not going to work unless the unsafe portions are updated to use Minecraft 1.5. Until the plugin author (or myself) update it, dota.barroncraft.com has also been reverted to 1.4.7.

Member

Nullreff commented Mar 13, 2013

After removing the version check from Shopkeepers, it's still crashing. It's not going to work unless the unsafe portions are updated to use Minecraft 1.5. Until the plugin author (or myself) update it, dota.barroncraft.com has also been reverted to 1.4.7.

@Framartin

This comment has been minimized.

Show comment
Hide comment
@Framartin

Framartin Mar 13, 2013

Noted. Thanks. If I can contribute to anything for the map, do not hesitate to tell me (but i'm not a developer).

Note : The first server (dota.barroncraft.com) seems to be bugged : doors of the red team are closed, but blue's ones are open.

Noted. Thanks. If I can contribute to anything for the map, do not hesitate to tell me (but i'm not a developer).

Note : The first server (dota.barroncraft.com) seems to be bugged : doors of the red team are closed, but blue's ones are open.

@Nullreff

This comment has been minimized.

Show comment
Hide comment
@Nullreff

Nullreff Mar 14, 2013

Member

The first server (dota.barroncraft.com) seems to be bugged : doors of the red team are closed, but blue's ones are open.

/surrender will reset the server

Member

Nullreff commented Mar 14, 2013

The first server (dota.barroncraft.com) seems to be bugged : doors of the red team are closed, but blue's ones are open.

/surrender will reset the server

@Nullreff

This comment has been minimized.

Show comment
Hide comment
@Nullreff

Nullreff Mar 14, 2013

Member

Ok, I managed to get it to work by decompiling and patching v1.11 with the following:

diff --git a/com/nisovin/shopkeepers/ShopkeepersPlugin.java b/com/nisovin/shopkeepers/ShopkeepersPlugin.java
index 6c2dbf5..86d2d19 100644
--- a/com/nisovin/shopkeepers/ShopkeepersPlugin.java
+++ b/com/nisovin/shopkeepers/ShopkeepersPlugin.java
@@ -64,18 +64,7 @@ public class ShopkeepersPlugin extends JavaPlugin {
         plugin = this;

         // load volatile code handler
-        String version = getServer().getVersion();
-        if (version.contains("(MC: 1.4.5)")) {
-            volatileCodeHandle = new VolatileCode_1_4_5();
-        } else if (version.contains("(MC: 1.4.6)")) {
-            volatileCodeHandle = new VolatileCode_1_4_6();
-        } else if (version.contains("(MC: 1.4.7)")) {
-            volatileCodeHandle = new VolatileCode_1_4_R1();
-        } else {
-            getLogger().severe("Incompatible server version: Shopkeepers plugin cannot be enabled.");
-            this.setEnabled(false);
-            return;
-        }
+        volatileCodeHandle = new VolatileCode_1_4_R1();

         // get config
         File file = new File(getDataFolder(), "config.yml");

It's downloadable here if anyone else is having this problem. I take no responsibility for what this may do to your server. The latest version of shopkeepers works with Minecraft 1.5. If you downloaded my patched plugin please update.

@Framartin If this comes back or the shopkeepers break again let me know.

Member

Nullreff commented Mar 14, 2013

Ok, I managed to get it to work by decompiling and patching v1.11 with the following:

diff --git a/com/nisovin/shopkeepers/ShopkeepersPlugin.java b/com/nisovin/shopkeepers/ShopkeepersPlugin.java
index 6c2dbf5..86d2d19 100644
--- a/com/nisovin/shopkeepers/ShopkeepersPlugin.java
+++ b/com/nisovin/shopkeepers/ShopkeepersPlugin.java
@@ -64,18 +64,7 @@ public class ShopkeepersPlugin extends JavaPlugin {
         plugin = this;

         // load volatile code handler
-        String version = getServer().getVersion();
-        if (version.contains("(MC: 1.4.5)")) {
-            volatileCodeHandle = new VolatileCode_1_4_5();
-        } else if (version.contains("(MC: 1.4.6)")) {
-            volatileCodeHandle = new VolatileCode_1_4_6();
-        } else if (version.contains("(MC: 1.4.7)")) {
-            volatileCodeHandle = new VolatileCode_1_4_R1();
-        } else {
-            getLogger().severe("Incompatible server version: Shopkeepers plugin cannot be enabled.");
-            this.setEnabled(false);
-            return;
-        }
+        volatileCodeHandle = new VolatileCode_1_4_R1();

         // get config
         File file = new File(getDataFolder(), "config.yml");

It's downloadable here if anyone else is having this problem. I take no responsibility for what this may do to your server. The latest version of shopkeepers works with Minecraft 1.5. If you downloaded my patched plugin please update.

@Framartin If this comes back or the shopkeepers break again let me know.

@Nullreff Nullreff closed this Mar 14, 2013

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment