Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check some error conditions for threads and throw #215

Merged
merged 7 commits into from Feb 17, 2018
Merged

Conversation

@barrucadu
Copy link
Owner

barrucadu commented Feb 16, 2018

Summary

Checks a bunch of error conditions around threading and calls fatal with some sensible message. Previously dejafu would just soldier on and end up in a weird state (although it would have to already be in a weird state to start with).

None of the errors are raised by the tests, which is good. I expect it would have been pretty obvious if we were (eg) creating two threads with the same ID, but it is comforting to have that explicitly checked.

@barrucadu barrucadu force-pushed the thread-invariants branch from e0830a4 to 6731ad7 Feb 16, 2018
@barrucadu barrucadu merged commit c3d98e5 into master Feb 17, 2018
2 checks passed
2 checks passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
@barrucadu barrucadu deleted the thread-invariants branch Feb 17, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
1 participant
You can’t perform that action at this time.