Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.Sign up
Flesh out live namespace #5
This PR makes some quality-of-life improvements to the live namespace. The highlights are:
- Copy over only the required apps - Fill in the EXTERNAL_DOMAIN_NAME - Get the jumpbox IP from terraform automatically
- GOVUK_ASSET_ROOT: which should be "" to serve from the current host - SECRET_KEY_BASE: which is generated anew for every app - RAILS_SERVE_STATIC_FILES: needed to serve assets in production SECRET_KEY_BASE generation is done by adding "SECRET_KEY_BASE-appname" entries to secrets with the value "GENERATED_SECRET_KEY_BASE". deploy.sh then replaces one GENERATED_SECRET_KEY_BASE at a time with a UUID. I'm not sure what the recommendations for a Rails secret key base are, but UUIDs are probably good enough for my purposes.
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments.