Present authorized scopes to user, post-auth #63
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, the scopes that were presented to the user (alongside their `me`) were the scopes that Micropublish requested, rather than the scopes returned by the authorization server. We should make sure we present those that were actually returned by the token endpoint. To match the intent, we should update our methods to note that they also return the `scope`, and make sure we update our session object with it.
jamietanna
changed the title
jamietanna
force-pushed
the
defect/scope
branch
from
cbba98f
to
7a740f4
Compare
|
This looks great! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Previously, the scopes that were presented to the user (alongside their
me) were the scopes that Micropublish requested, rather than thescopes returned by the authorization server.
We should make sure we present those that were actually returned by the
token endpoint.
To match the intent, we should update our methods to note that they also
return the
scope, and make sure we update our session object with it.