Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature request: configurable threshold for indicator warnings #1049

Open
peterjaap opened this issue Jun 10, 2020 · 2 comments
Open

Feature request: configurable threshold for indicator warnings #1049

peterjaap opened this issue Jun 10, 2020 · 2 comments

Comments

@peterjaap
Copy link

peterjaap commented Jun 10, 2020

While browsing on my app, I usually glance at the debugbar to see if my memory usage and request duration is within my normal limits.

It would be great to have a configuration setting in config/debugbar.php that sets a memory_usage_warning_threshold (in kilobytes) and a request_duration_warning_threshold (in milliseconds).

If the memory usage/request duration then exeeds this threshold, the memory usage/request duration block in the debugbar lights up, something like this;

image

This way, I can quickly see something's wrong without having actually having to look at the values themselves.

@peterjaap peterjaap changed the title Feature request: configurable threshold for clearer warnings Feature request: configurable threshold for indicator warnings Jun 10, 2020
@stale
Copy link

stale bot commented Aug 9, 2020

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.
If this issue is still present on the latest version of this library on supported Laravel versions, please let us know by replying to this issue so we can investigate further.
Thank you for your contribution! Apologies for any delayed response on our side.

@stale stale bot added the stale label Aug 9, 2020
@stale stale bot closed this as completed Aug 16, 2020
@barryvdh barryvdh reopened this Aug 16, 2020
@stale stale bot removed the stale label Aug 16, 2020
@miken32
Copy link

miken32 commented Oct 6, 2020

I agree this would be nice, but I don't see any facility in the php-debugbar side of things to specify custom HTML or CSS classes for an indicator.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants