As mentioned above, Turbolinks intercepts link clicks and makes an AJAX call for the content of the requested page. It then swaps out the content of the body, which means in this case that all of the JS that Debugbar injects into the body is re-run every page click/swap. So we do want Debugbar to be injected unlike in #910 , we just want Turbolinks to stop reloading the scripts tags.

I'm specifically seeing the error "jQuery is not defined" come up because jQuery.noConflict() has been run once initially and is then run again on page swaps but window.jQuery has already been cleared. The quick/dirty fix I've found is to simply wrap the no-conflict statement in JavascriptRenderer@renderHead in if(jQuery){} which prevents it from re-running. All the other JS runs again, but this doesn't seem to cause any other noticeable issues: the Debugbar updates and works as expected.

A proper fix might be to add a configuration option like forTurbolinks(true) to add the data-turbolinks-permanent on the script blocks so that Turbolinks does not re-run them. Alternatively we could add some way to hook into renderHead to adjust the output. Thoughts?

Example of what could be added to make Turbolinks happy. Makes the CSS 'permanent' so it is not reloaded and tells the script blocks to only eval on page initialization rather than each swap: https://github.com/ahamilton9/laravel-debugbar/pull/1/files

Uh oh!

Support turbolinks #908

Description

Metadata

Metadata

Assignees

Labels

Projects

Milestone

Relationships

Development

Issue actions