New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switching Protocol.encodeBytes to use Base64. refs #91 #95

Merged
merged 1 commit into from Jan 2, 2012

Conversation

Projects
None yet
3 participants
@fdintino
Contributor

fdintino commented Dec 21, 2011

I changed Protocol.encodeBytes() to use Base64 encoding to fix the issue of bytes in the range of 0xD8 - 0xDF being sent as 0x00 (issue #91).

The Base64.java file is from MiGBase64.

@bartdag

This comment has been minimized.

Show comment
Hide comment
@bartdag

bartdag Dec 23, 2011

Owner

Thanks for your patch! This is really helpful! I will review it and merge it during the holidays.

Owner

bartdag commented Dec 23, 2011

Thanks for your patch! This is really helpful! I will review it and merge it during the holidays.

@agronholm

This comment has been minimized.

Show comment
Hide comment
@agronholm

agronholm Dec 23, 2011

It's still wasteful compared to sending a length + raw bytes, but any working fix is welcome for now.

agronholm commented Dec 23, 2011

It's still wasteful compared to sending a length + raw bytes, but any working fix is welcome for now.

bartdag added a commit that referenced this pull request Jan 2, 2012

Merge pull request #95 from theatlantic/protocol-base64-encoding
Switching Protocol.encodeBytes to use Base64. refs #91

@bartdag bartdag merged commit 9fde60f into bartdag:master Jan 2, 2012

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment