Remove `lock_enqueue` functionality #2

Closed
nicholaides opened this Issue Nov 28, 2012 · 3 comments

2 participants

@nicholaides

The lock_enqueue functionality should be removed because defunkt/resque-lock implements this functionality, has tests, and uses the deadlock free locking pattern from http://redis.io/commands/setnx.

@bartolsthoorn

Yeah I copied the functionality of lock_enqueue of resque-lock, but it would be better to leave it in the resque-lock and include it as a dependency. Only recently (like 22 days ago) resque-lock added a deadlock free algorithm, at the time of creating resque-workers-lock it was not deadlock-proof, so I rolled my own.

I don't have time to replace resque-lock's method right now though, feel free to commit it and I'll merge it in!

@bartolsthoorn

@nicholaides thanks for the commits, I'm about to merge and publish the gem. Would you mind if I added you as an author in the gemspec file? Since you contributed so much. :)

@nicholaides

@bartolsthoorn I'd be honored. :) Also, to be fair, these I created these commits while pairing with Jason Garber (https://github.com/jgarber). I wouldn't want to get credit without him.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment