Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

breaks cross-platform "Remote - SSH" coding #279

Open
joelhock opened this issue May 3, 2019 · 4 comments

Comments

Projects
None yet
5 participants
@joelhock
Copy link

commented May 3, 2019

extension version 3.0.38
insiders version 1.34.0 2019-05-01T00:12:25.110Z
local os: mac
remote os: linux

Microsoft's new remote coding setup splits the UI vscode instance from the back-end vscode instance https://code.visualstudio.com/blogs/2019/05/02/remote-development

trying to enable spellright as a remote extension causes the remote connection to go into a sort of a zombie mode (and it does not work when forced to be a ui extension). it might be using launching the wrong node library (since the UI instance is on a different OS in my setup from the backend) and bringing down the remote extension process. more info https://code.visualstudio.com/api/advanced-topics/remote-extensions

@jd4no

This comment has been minimized.

Copy link

commented May 6, 2019

To expand on this, the extension doesn't just break cross-platform remote. I was coming here to report that it breaks any remote development in vscode, including connecting to a WSL folder.

@bartosz-antosik

This comment has been minimized.

Copy link
Owner

commented May 7, 2019

Hi! I will have a look at this.

@ahmadawais

This comment has been minimized.

Copy link

commented May 8, 2019

^Thank you, for looking into it. I came here to report the same.

@rebornix rebornix referenced this issue May 8, 2019

Open

WIP: use napi spellchecker #280

1 of 3 tasks complete
@rebornix

This comment has been minimized.

Copy link

commented May 8, 2019

The reason that it broke is VS Code remote runs in a pure Node.js environment whose header is different from Electron one. An easy fix is having prebuilt binaries for pure node but it will increase the size of bundled binaries significantly.

I proposed moving to napi-spellchecker and then we only care about platforms. There is already some work happening in #280.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.