From bf8208e44705ca6cc37aa1ae9527d1a7cdb16748 Mon Sep 17 00:00:00 2001 From: Mike Perham Date: Mon, 7 Nov 2011 20:35:31 -0800 Subject: [PATCH] Remove 1.9 requirement for Batch, fixes #42 --- examples/batch.rb | 5 ++++- lib/girl_friday/batch.rb | 2 +- test/test_batch.rb | 2 +- test/test_girl_friday_queue.rb | 2 +- 4 files changed, 7 insertions(+), 4 deletions(-) diff --git a/examples/batch.rb b/examples/batch.rb index 1027905..89ffe86 100644 --- a/examples/batch.rb +++ b/examples/batch.rb @@ -7,11 +7,14 @@ class UrlProcessor URLS = %w(http://www.bing.com http://www.google.com http://www.yahoo.com) def parallel - batch = GirlFriday::Batch.new(URLS, :size => 3) do |url| + batch = GirlFriday::Batch.new(nil, :size => 3) do |url| html = open(url) doc = Nokogiri::HTML(html.read) doc.css('span').count end + URLS.each do |url| + batch << url + end p URLS.zip(batch.results) end diff --git a/lib/girl_friday/batch.rb b/lib/girl_friday/batch.rb index 3e4ad6f..1405faf 100644 --- a/lib/girl_friday/batch.rb +++ b/lib/girl_friday/batch.rb @@ -12,7 +12,7 @@ module GirlFriday # # TODO Errors are not handled well at all. class Batch - def initialize(enumerable=nil, options, &block) + def initialize(enumerable=nil, options={}, &block) @queue = GirlFriday::Queue.new(:batch, options, &block) @complete = 0 @size = 0 diff --git a/test/test_batch.rb b/test/test_batch.rb index 3fd97df..89630a2 100644 --- a/test/test_batch.rb +++ b/test/test_batch.rb @@ -41,7 +41,7 @@ def test_batch_timeout end def test_empty_batch - batch = GirlFriday::Batch.new(:size => 4) do |msg| + batch = GirlFriday::Batch.new(nil, :size => 4) do |msg| sleep msg 'x' end diff --git a/test/test_girl_friday_queue.rb b/test/test_girl_friday_queue.rb index b744fa3..a24ac82 100644 --- a/test/test_girl_friday_queue.rb +++ b/test/test_girl_friday_queue.rb @@ -1,6 +1,6 @@ require 'helper' -class TestGirlFriday < MiniTest::Unit::TestCase +class TestGirlFridayQueue < MiniTest::Unit::TestCase class TestErrorHandler include MiniTest::Assertions