Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incorrect unicorn.config for PropertyGridForm #47

Closed
svenkle opened this issue Aug 14, 2019 · 2 comments

Comments

@svenkle
Copy link

commented Aug 14, 2019

Describe the bug
Default unicorn serialization configuration file doesn't include PropertyGridForm - this means that if you include this package into your solution the PropertyGridForm changes will not be pushed up to each environment (similar to this https://codeandlearnspot.wordpress.com/2019/07/14/sitecore-forms-extensions-tds-sync-propertygridform-js-error/).

<include database="core" path="/sitecore/client/Applications/FormsBuilder/Components/Layouts/PropertyGridForm/PageSettings">
              <exclude children="true">
                <except name="FieldBindingTokensDataSource" />
                <except name="Settings" includeChildren="false" />
                <except name="Settings/Captcha" />
                <except name="Settings/FileUpload" />
                <except name="Settings/Hidden" />
                <except name="Settings/RawHtml" />
                <except name="Common" includeChildren="false" />
                <except name="Common/Details" includeChildren="false" />
                <except name="Common/Details/AllowedContentTypes" />
                <except name="Common/Details/MaxFileSize" />
                <except name="Common/Bindings" includeChildren="false"/>
                <except name="Common/Sections" includeChildren="false"/>
                <except name="Common/Sections/BindingsExpander" />
              </exclude>
            </include>

Should be:

<include database="core" path="/sitecore/client/Applications/FormsBuilder/Components/Layouts/PropertyGridForm">
              <exclude children="true">
                <except name="PageSettings" includeChildren="false"/>
                <except name="PageSettings/FieldBindingTokensDataSource" />
                <except name="PageSettings/Settings" includeChildren="false" />
                <except name="PageSettings/Settings/Captcha" />
                <except name="PageSettings/Settings/FileUpload" />
                <except name="PageSettings/Settings/Hidden" />
                <except name="PageSettings/Settings/RawHtml" />
                <except name="PageSettings/Common" includeChildren="false" />
                <except name="PageSettings/Common/Details" includeChildren="false" />
                <except name="PageSettings/Common/Details/AllowedContentTypes" />
                <except name="PageSettings/Common/Details/MaxFileSize" />
                <except name="PageSettings/Common/Bindings" includeChildren="false"/>
                <except name="PageSettings/Common/Sections" includeChildren="false"/>
                <except name="PageSettings/Common/Sections/BindingsExpander" />
              </exclude>
            </include>```

@bartverdonck bartverdonck self-assigned this Aug 20, 2019

@bartverdonck

This comment has been minimized.

Copy link
Owner

commented Aug 20, 2019

Hi,

Thanks for reporting, but there is no unicorn config for this project. So it is unlikely that the unicorn config is incorrect.

Should unicorn be added into the project, I will take your remark in consideration.

Best regards.

@svenkle

This comment has been minimized.

Copy link
Author

commented Aug 20, 2019

I have no idea where this config file came from then :| All good 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.