-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
byProps/byState should match all keys #61
Comments
Thanks for reporting and for the test case. I was able to pin point the error, I'm on my birthday holidays at the moment, but will fix this ASAP early next week along with #60 . |
Should be fixed in v1.9.0. |
@baruchvlz I still find current behavior unexpected. By writing |
@rousku The current match returns true if at least one of the properties match. There could be an optional flag to make it a strict match. If you like you could open a PR and I would gladly review it :) |
Current behavior
When passing a matcher with multiple keys,
.byProps
/.byState
returns nodes that match any one of the given keys.Example:
Expected behavior
.byProps
/.byState
returns nodes that match ALL of the given keys.Example:
Failing test case: ooorayray@b502b83
The text was updated successfully, but these errors were encountered: