From 1b6aa462f83d345f7117b177ce5cfa2b1cd82955 Mon Sep 17 00:00:00 2001 From: "copilot-swe-agent[bot]" <198982749+Copilot@users.noreply.github.com> Date: Tue, 20 Jan 2026 22:06:03 +0000 Subject: [PATCH 1/4] Initial plan From 2f6b951b76e917ca840086eb836abcb65d57a1d5 Mon Sep 17 00:00:00 2001 From: "copilot-swe-agent[bot]" <198982749+Copilot@users.noreply.github.com> Date: Tue, 20 Jan 2026 22:08:48 +0000 Subject: [PATCH 2/4] Fix incorrect test assertion in test_user_exporters_plus_env_exporter Co-authored-by: CorentinGS <43623834+CorentinGS@users.noreply.github.com> --- tests/observability/test_multi_exporters.py | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/tests/observability/test_multi_exporters.py b/tests/observability/test_multi_exporters.py index 349aaf1..e39d96d 100644 --- a/tests/observability/test_multi_exporters.py +++ b/tests/observability/test_multi_exporters.py @@ -130,9 +130,10 @@ def test_user_exporters_plus_env_exporter(self, mock_otlp_exporter): # Verify both exporters were used provider = manager._tracer_provider self.assertIsInstance(provider, TracerProvider) - # Should have 2 exporters + 4 Basalt processors = 6 total processors + # Should have 1 exporter + 4 Basalt processors = 5 total processors # Basalt processors: Context, CallEvaluator, ShouldEvaluate, AutoInstrumentation - self.assertEqual(len(provider._active_span_processor._span_processors), 6) + # Note: Environment exporter is only used if no user exporter is provided + self.assertEqual(len(provider._active_span_processor._span_processors), 5) def test_mixed_console_and_otlp_exporters(self): """Test mix of ConsoleSpanExporter and regular exporters.""" From ea570dfc492585e160321999a188c77da7b17515 Mon Sep 17 00:00:00 2001 From: "copilot-swe-agent[bot]" <198982749+Copilot@users.noreply.github.com> Date: Tue, 20 Jan 2026 22:10:05 +0000 Subject: [PATCH 3/4] Update test docstring to reflect actual behavior Co-authored-by: CorentinGS <43623834+CorentinGS@users.noreply.github.com> --- tests/observability/test_multi_exporters.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tests/observability/test_multi_exporters.py b/tests/observability/test_multi_exporters.py index e39d96d..eff36d5 100644 --- a/tests/observability/test_multi_exporters.py +++ b/tests/observability/test_multi_exporters.py @@ -113,7 +113,7 @@ def test_empty_list_uses_console_exporter(self): @mock.patch.dict("os.environ", {"BASALT_OTEL_EXPORTER_OTLP_ENDPOINT": "http://localhost:4318"}, clear=False) @mock.patch("basalt.observability.instrumentation.OTLPSpanExporter") def test_user_exporters_plus_env_exporter(self, mock_otlp_exporter): - """Test that user exporters are combined with environment exporter.""" + """Test that user exporters are used instead of environment exporter.""" # Mock the OTLP exporter creation mock_env_exporter = mock.Mock() mock_otlp_exporter.return_value = mock_env_exporter From f6411fdee289ea0e123610e9aedce9f9e763cca8 Mon Sep 17 00:00:00 2001 From: "copilot-swe-agent[bot]" <198982749+Copilot@users.noreply.github.com> Date: Tue, 20 Jan 2026 22:11:03 +0000 Subject: [PATCH 4/4] Update comment to reflect user exporter was used Co-authored-by: CorentinGS <43623834+CorentinGS@users.noreply.github.com> --- tests/observability/test_multi_exporters.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tests/observability/test_multi_exporters.py b/tests/observability/test_multi_exporters.py index eff36d5..fb84cb8 100644 --- a/tests/observability/test_multi_exporters.py +++ b/tests/observability/test_multi_exporters.py @@ -127,7 +127,7 @@ def test_user_exporters_plus_env_exporter(self, mock_otlp_exporter): manager = InstrumentationManager() manager.initialize(config) - # Verify both exporters were used + # Verify user exporter was used provider = manager._tracer_provider self.assertIsInstance(provider, TracerProvider) # Should have 1 exporter + 4 Basalt processors = 5 total processors