Add getSubscriptionStatus method #110
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
✅ Heimdall Review Status
|
spencerstock
force-pushed
the
spencer/getsubstatus
branch
from
50189ed to
99e9ca5
Compare
spencerstock
force-pushed
the
spencer/getsubstatus
branch
from
99e9ca5 to
f5ff77c
Compare
spencerstock
force-pushed
the
spencer/getsubstatus
branch
from
f5ff77c to
44f34ab
Compare
fan-zhang-sv
approved these changes
Sep 8, 2025
Comment on lines
+76
to
+100
| if (permission.chainId !== expectedChainId) { | ||
| // Determine if the subscription is on mainnet or testnet | ||
| const isSubscriptionOnMainnet = permission.chainId === CHAIN_IDS.base; | ||
| const isSubscriptionOnTestnet = permission.chainId === CHAIN_IDS.baseSepolia; | ||
|
|
||
| let errorMessage: string; | ||
| if (testnet && isSubscriptionOnMainnet) { | ||
| errorMessage = | ||
| 'The subscription was requested on testnet but is actually a mainnet subscription'; | ||
| } else if (!testnet && isSubscriptionOnTestnet) { | ||
| errorMessage = | ||
| 'The subscription was requested on mainnet but is actually a testnet subscription'; | ||
| } else { | ||
| // Fallback for unexpected chain IDs | ||
| errorMessage = `Subscription is on chain ${permission.chainId}, expected ${expectedChainId} (${testnet ? 'Base Sepolia' : 'Base'})`; | ||
| } | ||
|
|
||
| throw new Error(errorMessage); | ||
| } | ||
|
|
||
| if (permission.permission.token.toLowerCase() !== expectedTokenAddress) { | ||
| throw new Error( | ||
| `Subscription is not for USDC token. Got ${permission.permission.token}, expected ${expectedTokenAddress}` | ||
| ); | ||
| } |
Collaborator
There was a problem hiding this comment.
could abstract these to some internal subscription helper for reuseability
arjun-dureja
approved these changes
Sep 8, 2025
| * console.log(`Recurring amount: $${status.recurringAmount}`); | ||
| * ``` | ||
| */ | ||
| export async function getSubscriptionStatus( |
Collaborator
There was a problem hiding this comment.
I noticed there's no tests for this, are there plans to add any?
| * @param currentTimestamp - Optional timestamp to use as "now" (defaults to current time) | ||
| * @returns The current period with start, end, and spend (0 for inferred periods) | ||
| */ | ||
| export function calculateCurrentPeriod( |
Collaborator
There was a problem hiding this comment.
Also should have a test
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changed? Why?
Added a new
getSubscriptionStatusmethod to the payment interface that allows checking the status of a subscription created via thesubscribemethod.added
prepareChargewhich wraps existing utils after doing some validationsHow was this tested?
manually + unit
How can reviewers manually test these changes?
subscribemethodgetSubscriptionStatuswith the returned subscription IDDemo/screenshots