feat(mainnet): set the Jovian parameters on Base Mainnet #532
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add SetJovianParameters.s.sol script - Configure .env with mainnet addresses and Jovian params - Update Makefile for mainnet multisig structure - Add README and validation file
Collaborator
✅ Heimdall Review Status
|
jackchuma
reviewed
Dec 2, 2025
Contributor
jackchuma
left a comment
jackchuma
left a comment
There was a problem hiding this comment.
Overall LGTM - only thing is we've been adding a FACILITATORS.md file to tasks lately - could you add one here as well? Reference: https://github.com/base/contract-deployments/blob/main/mainnet/2025-11-10-increase-gas-and-elasticity-limit/FACILITATOR.md
Contributor
Author
added: aa0d95d |
xenoliss
previously approved these changes
Dec 3, 2025
jackchuma
previously approved these changes
Dec 3, 2025
mainnet/2025-12-04-set-jovian-parameters/validations/base-signer.json
Outdated
Show resolved
Hide resolved
cb-heimdall
dismissed stale reviews from xenoliss and jackchuma
Approved review 3535774609 from xenoliss is now dismissed due to new commit. Re-request for approval.
jackchuma
approved these changes
Dec 3, 2025
roger-bai-coinbase
approved these changes
Dec 3, 2025
Collaborator
|
Review Error for roger-bai-coinbase @ 2025-12-03 16:55:37 UTC |
xenoliss
approved these changes
Dec 4, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This task sets the minimum base fee to 200,000 wei (2e-4 gwei) and the DA footprint scalar to 312 on Base Mainnet.
200,000 wei was chosen based on the p5 base fee observed on Base Mainnet from November 7 to 14 and rounded down slightly to get a nice number. The DA footprint was calculated from
da_footprint_gas_scalar = block_gas_target_throughput / (blob_target * 128,000 bytes / 12 seconds * estimation_ratio)whereblock_gas_target_throughput = 30,000,000 gas/sec,blob_target = 6, andestimation_ratio = 1.5.30,000,000 / (6 * 128,000 / 12 * 1.5) = 312.5, which was rounded down to the nearest integer.This task was adapted from
sepolia/2025-11-18-set-jovian-parameters(#515), the Sepolia version of this task.