fix(docs): add .slice(2) to dataSuffix hex stripping in builder codes…#1521
Open
0xchainer wants to merge 1 commit into
Open
fix(docs): add .slice(2) to dataSuffix hex stripping in builder codes…#15210xchainer wants to merge 1 commit into
0xchainer wants to merge 1 commit into
Conversation
Collaborator
🟡 Heimdall Review Status
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
In tmp-builder-codes-outline.mdx, the dataSuffix hex stripping is inconsistent across examples. Some examples correctly strip the 0x prefix (dataSuffix.slice(2)) but the EOA and ERC-4337 sections don't:
Since dataSuffix has 0x prefix, this produces malformed double-prefixed hex strings.
Fix
Added .slice(2) to both:
Matches existing pattern in lines 164, 175, 307, 319.
Closes [Bug] Inconsistent dataSuffix hex stripping: slice(2) used in some examples but not others #1474