From 8fcbe8aae32ac7c592d5b838ee018d7b95c5158b Mon Sep 17 00:00:00 2001 From: GarmashAlex Date: Wed, 1 Oct 2025 16:31:32 +0300 Subject: [PATCH 1/3] perf(flashblocks): remove redundant clones in get_latest_block and reorg recheck --- crates/flashblocks-rpc/src/state.rs | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/crates/flashblocks-rpc/src/state.rs b/crates/flashblocks-rpc/src/state.rs index 3e19164..6a61da6 100644 --- a/crates/flashblocks-rpc/src/state.rs +++ b/crates/flashblocks-rpc/src/state.rs @@ -271,7 +271,7 @@ where // If we had a reorg, we need to reset all flashblocks state let tracked_txns = pending_blocks.get_transactions_for_block(block.number); let tracked_txn_hashes: HashSet<_> = - tracked_txns.clone().iter().map(|tx| tx.tx_hash()).collect(); + tracked_txns.iter().map(|tx| tx.tx_hash()).collect(); let block_txn_hashes: HashSet<_> = block.body().transactions().map(|tx| tx.tx_hash()).collect(); From 33ae39fc21b644e137fa1c24d9e7ba108f31adb4 Mon Sep 17 00:00:00 2001 From: GarmashAlex Date: Wed, 1 Oct 2025 16:31:53 +0300 Subject: [PATCH 2/3] perf(flashblocks): remove redundant clones in get_latest_block and reorg recheck --- crates/flashblocks-rpc/src/pending_blocks.rs | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/crates/flashblocks-rpc/src/pending_blocks.rs b/crates/flashblocks-rpc/src/pending_blocks.rs index dba4a1b..26fd561 100644 --- a/crates/flashblocks-rpc/src/pending_blocks.rs +++ b/crates/flashblocks-rpc/src/pending_blocks.rs @@ -190,14 +190,13 @@ impl PendingBlocks { let block_transactions: Vec = self.get_transactions_for_block(block_number); let transactions = if full { - BlockTransactions::Full(block_transactions.clone()) + BlockTransactions::Full(block_transactions) } else { let tx_hashes: Vec = block_transactions - .clone() .iter() .map(|tx| tx.tx_hash()) .collect(); - BlockTransactions::Hashes(tx_hashes.clone()) + BlockTransactions::Hashes(tx_hashes) }; RpcBlock:: { From f727ed67276cdad51bb3f49bcd5c3047f33459f3 Mon Sep 17 00:00:00 2001 From: GarmashAlex Date: Thu, 2 Oct 2025 18:07:10 +0300 Subject: [PATCH 3/3] fmt --- crates/flashblocks-rpc/src/pending_blocks.rs | 5 +---- 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/crates/flashblocks-rpc/src/pending_blocks.rs b/crates/flashblocks-rpc/src/pending_blocks.rs index 26fd561..65c0c44 100644 --- a/crates/flashblocks-rpc/src/pending_blocks.rs +++ b/crates/flashblocks-rpc/src/pending_blocks.rs @@ -192,10 +192,7 @@ impl PendingBlocks { let transactions = if full { BlockTransactions::Full(block_transactions) } else { - let tx_hashes: Vec = block_transactions - .iter() - .map(|tx| tx.tx_hash()) - .collect(); + let tx_hashes: Vec = block_transactions.iter().map(|tx| tx.tx_hash()).collect(); BlockTransactions::Hashes(tx_hashes) };