New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Possible reflected XSS in Firefox when fetching an invalid check name #26

Closed
rosa opened this Issue Nov 9, 2018 · 0 comments

Comments

Projects
None yet
1 participant
@rosa
Copy link
Member

rosa commented Nov 9, 2018

When passing an invalid check name to ChecksController#show, an exception is raised, resulting in a 406 response with the following body:

"No check named '#{name}'"

Firefox renders that body, and if the name includes any JavaScript code via <script> tags, it'll be executed.

@anoldguy anoldguy closed this in #25 Nov 9, 2018

anoldguy added a commit that referenced this issue Nov 9, 2018

Merge pull request #25 from basecamp/reflected-xss-fix
Remove unescaped check name from not-found output, fixes #26.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment