Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added internationalization #50

Closed
wants to merge 2 commits into from

Conversation

julianlecalvez
Copy link

Hi,

I added internationalization for one of my project which uses local_time.
Here are my modifications.

Julian

@javan
Copy link
Contributor

javan commented Nov 7, 2015

Thanks @julianlecalvez! I think instead of using a separate window.local_time object and framing this as internationalization, I'd prefer to make all of LocalTime's language and date/time formats configurable. I'm picturing something like:

LocalTime.config =
  lang:
    sunday: "Sunday"
    monday: "Monday"
    minute: "minute"
  time:
    default: "%Hh%M"

Then in your app you can modify LocalTime.config after including local_time.js. What do you think?

@kevcha kevcha mentioned this pull request Feb 23, 2016
Closed
@javan javan mentioned this pull request Mar 17, 2016
Merged
3 tasks
@javan javan closed this in #55 Aug 7, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants