Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

I18n #53

Closed
wants to merge 2 commits into from

Conversation

@kevcha
Copy link

commented Feb 23, 2016

Hi,
following #50, I tried to add i18n with @javan recommendations.

The basic idea is to let people override javascript object LocalTime.i18n with custom labels.

Let me know what do think about this :)

kevcha added 2 commits Feb 5, 2016
@Xosmond

This comment has been minimized.

Copy link

commented Mar 12, 2016

Waiting! :)))

@javan javan referenced this pull request Mar 17, 2016
Merged
3 of 3 tasks complete
@javan

This comment has been minimized.

Copy link
Member

commented Mar 17, 2016

Thanks @kevcha! I merged your branch into #55 and made a quite a few changes. I'm planning to release it in version 2.0. Let me know what you think.

@kevcha

This comment has been minimized.

Copy link
Author

commented Apr 12, 2016

Sorry for the delay :/ Your PR #55 looks really good ! 👍

@williamparso

This comment has been minimized.

Copy link

commented May 29, 2017

Can anyone explain how to do this? i try loading the gem this way gem 'local_time', git: 'https://github.com/basecamp/local_time', branch: '2-0'
then i write inn my assets/application.js
#= require local_time
#= require local_time_language in this one i set the LocalTime.i18n as it says in the readme and it seems i actually setting them fine as i see in console:

Object {weekdays: "Domingo Lunes Martes Miercoles Jueves Viernes Sabado", months: "Enero Febrero Marzo Abril Mayo Junio Julio Agosto Septiembre Octubre Noviembre Diciembre" .. ETC

but i do in my view local_time 2.months.from_now to test andthe result is still in english, can someone help me on this?

@javan javan closed this in #55 Aug 7, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.