Add compatibility with rails 5 #54
Merged
Conversation
This will raise an syntax error on 1.9.3 https://travis-ci.org/basecamp/marginalia/jobs/103911750 |
Fixed |
@arthurnn All right with PR or need something to modify? |
arthurnn
pushed a commit
that referenced
this pull request
Mar 5, 2016
Add compatibility with rails 5
thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
I get the following error when using this gem with rails 5.0.0.beta1:
This PR adds compatibility with new version rails and fix this error.