Fixes Issue #84 - Per App Timeout/Workers #205

Merged
merged 2 commits into from Sep 7, 2011

Conversation

Projects
None yet
3 participants
@wsclock
Contributor

wsclock commented Aug 24, 2011

Will load these now from environment variables at initialization time, or default back to global config.

@cjolly

This comment has been minimized.

Show comment Hide comment
@cjolly

cjolly Aug 26, 2011

Contributor

+1

Contributor

cjolly commented Aug 26, 2011

+1

src/rack_application.coffee
- size: @configuration.workers
- idle: @configuration.timeout * 1000
+ size: (env && env['POW_WORKERS']) ? @configuration.workers
+ idle: ((env && env['POW_TIMEOUT']) ? @configuration.timeout) * 1000

This comment has been minimized.

Show comment Hide comment
@josh

josh Sep 7, 2011

Contributor

coffee tip: env?.POW_WORKERS

@josh

josh Sep 7, 2011

Contributor

coffee tip: env?.POW_WORKERS

This comment has been minimized.

Show comment Hide comment
@wsclock

wsclock Sep 7, 2011

Contributor

Thanks. I've made the change. Appreciate the input.

@wsclock

wsclock Sep 7, 2011

Contributor

Thanks. I've made the change. Appreciate the input.

@josh

This comment has been minimized.

Show comment Hide comment
@josh

josh Sep 7, 2011

Contributor

👍

Contributor

josh commented Sep 7, 2011

👍

josh added a commit that referenced this pull request Sep 7, 2011

Merge pull request #205 from wsclock/per_app_config
Fixes Issue #84 - Per App Timeout/Workers

@josh josh merged commit e973735 into basecamp:master Sep 7, 2011

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment