New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid inheriting text attributes from parent block elements #163

Merged
merged 2 commits into from Jan 20, 2016

Conversation

Projects
None yet
1 participant
@javan
Member

javan commented Jan 19, 2016

Fixes scenario where a block's styles match those of a text attribute. If the HTML was reparsed, the block's text would receive those attributes.

For example, if a page has italic styles for quotes:

blockquote {
  font-style: italic;
}

This would happen on reparse:

block-styles-before

After this change:
block-styles-after

javan added a commit that referenced this pull request Jan 20, 2016

Merge pull request #163 from basecamp/avoid-parsing-text-attributes-f…
…rom-block

Avoid inheriting text attributes from parent block elements

@javan javan merged commit 5e056c6 into master Jan 20, 2016

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@javan javan deleted the avoid-parsing-text-attributes-from-block branch Jan 20, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment