New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix that selections remained expanded in Firefox after a composition #164

Merged
merged 1 commit into from Jan 21, 2016

Conversation

Projects
None yet
1 participant
@javan
Member

javan commented Jan 20, 2016

Because Firefox completes compositions in the last compositionupdate and then sends compositionend, Trix wouldn't perform a render because the mutation occurs while the composition is still happening, and Trix ignores mutations until they're complete.

In Chrome (and all other browsers I've tested), this is the sequence of events and mutations when composing é by pressing alt+e, then e:

compositionupdate, data = ´
elementDidMutate, composing? true
compositionend, data = é
elementDidMutate, composing? false

The same sequence in Firefox:

compositionupdate, data = ´ 
elementDidMutate, composing? true 
compositionupdate, data = é 
elementDidMutate, composing? true 
compositionend, data = é 

Before this change:
ff-composition
After:
ff-composition-after

javan added a commit that referenced this pull request Jan 21, 2016

Merge pull request #164 from basecamp/fix-firefox-composition-selection
Fix that selections remained expanded in Firefox after a composition

@javan javan merged commit 3df5272 into master Jan 21, 2016

@javan javan deleted the fix-firefox-composition-selection branch Jan 21, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment