New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Typing formatted text fixes #243

Merged
merged 6 commits into from Jun 16, 2016

Conversation

Projects
None yet
1 participant
@javan
Member

javan commented May 20, 2016

contenteditable naturally types over <br>s at the end of a block element, and we need to account for their removal now that we’re correctly summarizing <br> mutations (1497f52). Discovered by @zachwaugh.

Before:
lost-formatting

After:
lost-formatting-after


Also accounts for mutations that occur on systems (like iOS) that perform auto-capitalization as you type.

Before:
capitalize-before

After:
capitalize-after

@javan javan force-pushed the expect-extra-br-mutation branch from 7bcc055 to 39308a6 Jun 16, 2016

javan added some commits May 20, 2016

Fix typing formatted text after a newline at the end of a block
contenteditable naturally types over <br>s at the end of a block element, and we need to account for their removal now that we’re correctly summarizing <br> mutations (1497f52).

@javan javan force-pushed the expect-extra-br-mutation branch from 39308a6 to 3040f4f Jun 16, 2016

@javan javan changed the title from Fix typing formatted text after a newline at the end of a block to Typing formatted text fixes Jun 16, 2016

@javan javan merged commit 65cdb0b into master Jun 16, 2016

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@javan javan deleted the expect-extra-br-mutation branch Jun 16, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment