New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Persist attachment editing #445

Merged
merged 7 commits into from Sep 29, 2017

Conversation

Projects
None yet
1 participant
@javan
Member

javan commented Sep 20, 2017

Problem: If a sync happens while editing an attachment, editing stops and the cursor collapses before it. So, if you're editing an attachment's caption while it uploads, that'll abruptly move the cursor out of the caption editing <textarea> and you'll be typing outside of the attachment.

Idea: Prevent syncing while editing attachments. And, while syncs are prevented, use the shadow element for serialization to ensure the <input> element's value stays current.

@javan javan added the WIP label Sep 20, 2017

@javan javan merged commit 57aa713 into master Sep 29, 2017

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@javan javan deleted the persist-attachment-editing-2 branch Sep 29, 2017

@javan javan removed the WIP label Sep 29, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment