Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Android: Ignore Chrome 65’s new composition events during cursor movement #487

Merged
merged 6 commits into from Mar 2, 2018

Conversation

@javan
Copy link
Contributor

@javan javan commented Feb 26, 2018

Attempting to get ahead of Chrome 65's composition event changes so Android isn't totally broken when it's released on March 6.

References:

javan added 5 commits Mar 1, 2018
This reverts commit 89c9544.

Handling “keyup” reintroduces the Android issue after the next cursor movement
We can’t rely on all other browsers to emit keyboard and/or input events during compositions. Especially not in the same order.

Fixes #48
The next compositionstart can come before the mutation so `didInput` needs to be flipped back to avoid handling it.
@javan javan merged commit 593f0e3 into master Mar 2, 2018
1 check passed
1 check passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@javan javan deleted the android/chrome-65-composition-hotfix branch Mar 2, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

1 participant