Skip to content

Safari: Fix inserting composed text in empty blocks #564

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

javan
Copy link
Contributor

@javan javan commented Nov 1, 2018

Tested using the Pinyin - Simplified Chinese keyboard and typing A space then B space, which should insert 啊不. This keyboard + key combo was reported in #396, but the same issue can be reproduced with U.S. keyboard compositions.

Before After
safari-before
ios-before
safari-after
ios-after

@javan javan force-pushed the safari/fix-composing-in-empty-blocks branch from 696f0de to 7814b1d Compare November 1, 2018 21:07
@javan javan force-pushed the safari/fix-composing-in-empty-blocks branch from 7814b1d to aa12e23 Compare November 1, 2018 21:26
@javan javan mentioned this pull request Jan 4, 2019
@stale
Copy link

stale bot commented Jan 31, 2019

This pull request has been automatically marked as stale after 90 days of inactivity. It will be closed if no further activity occurs.

@javan javan closed this in #580 Feb 21, 2019
@javan javan deleted the safari/fix-composing-in-empty-blocks branch February 21, 2019 17:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant