Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add For Attribute to Stand Alone Label Component #262

Closed
bdlb77 opened this issue Oct 27, 2019 · 3 comments
Closed

Add For Attribute to Stand Alone Label Component #262

bdlb77 opened this issue Oct 27, 2019 · 3 comments
Assignees
Labels
bug Something isn't working good first issue Good for newcomers hacktoberfest
Milestone

Comments

@bdlb77
Copy link
Collaborator

bdlb77 commented Oct 27, 2019

What is the current behaviour?
When using the label component from class Label < Matestack::Ui::Core::Component::Static;end , no options[:for] is defined in the class. This makes it so the <label> tag cannot find the correct <input>, <meter>, or corresponding HTML element that it is intended for.

label for: 'meter', text: "Meter Label"
meter id: 'meter', value: 0.4

returns

<label>Meter Label</label>
<meter id="meter" value="0.4"></meter>

If the current behaviour is a bug, please provide the steps to reproduce and if possible a minimal demo of the problem. Your bug might get fixed faster if we can run your code and it doesn't have extra dependencies. Add a link to a sample repo and/or any relevant code below:

What is the expected behaviour?

label for: 'meter', text: "Meter Label"
meter id: 'meter', value: 0.4

returns

<label for="meter">Meter Label</label>
<meter id="meter" value="0.4"></meter>
@bdlb77 bdlb77 added bug Something isn't working good first issue Good for newcomers hacktoberfest labels Oct 27, 2019
@bdlb77 bdlb77 self-assigned this Oct 27, 2019
@bdlb77 bdlb77 mentioned this issue Oct 27, 2019
3 tasks
@ewelinasobora
Copy link

I'm on it.

@bdlb77
Copy link
Collaborator Author

bdlb77 commented Oct 27, 2019

I'm on it.

I had Already done the pull request for this! sorry

@pascalwengerter pascalwengerter added this to the 0.7.3 milestone Oct 28, 2019
@pascalwengerter
Copy link
Contributor

Fixed via #263 thanks to @bdlb77 🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working good first issue Good for newcomers hacktoberfest
Projects
None yet
Development

No branches or pull requests

3 participants