From 181c4781db1b81574ff71aa0acb19999b974339f Mon Sep 17 00:00:00 2001 From: sadan <117494111+sadan4@users.noreply.github.com> Date: Sat, 4 Oct 2025 01:20:32 -0400 Subject: [PATCH 1/2] fix: properly dispose of the client this fixes a bug introduced in 119f32a8ed55ab7fe22d5291a258618584061af7 (and somehow not noticed in 6eb243e45a10e8b6496161c904fb5b17bbb1fdcf ????) --- vscode-client/src/extension.ts | 9 +++------ 1 file changed, 3 insertions(+), 6 deletions(-) diff --git a/vscode-client/src/extension.ts b/vscode-client/src/extension.ts index dd65470f9..eed2883fa 100644 --- a/vscode-client/src/extension.ts +++ b/vscode-client/src/extension.ts @@ -9,7 +9,7 @@ import { TransportKind, } from 'vscode-languageclient/node' -let client: LanguageClient +let client: LanguageClient | undefined export const CONFIGURATION_SECTION = 'bashIde' // matching the package.json configuration section @@ -60,7 +60,7 @@ export async function activate(context: ExtensionContext) { }, } - const client = new LanguageClient('Bash IDE', 'Bash IDE', serverOptions, clientOptions) + client = new LanguageClient('Bash IDE', 'Bash IDE', serverOptions, clientOptions) client.registerProposedFeatures() try { @@ -71,8 +71,5 @@ export async function activate(context: ExtensionContext) { } export function deactivate(): Thenable | undefined { - if (!client) { - return undefined - } - return client.stop() + return client?.stop() } From 295659ea4993695b439e6e3bb44478fb78b9a484 Mon Sep 17 00:00:00 2001 From: Kenneth Skovhus Date: Sun, 5 Oct 2025 10:42:17 +0200 Subject: [PATCH 2/2] Prepare for releasing client 1.43.1 --- vscode-client/CHANGELOG.md | 3 +++ vscode-client/package.json | 2 +- 2 files changed, 4 insertions(+), 1 deletion(-) diff --git a/vscode-client/CHANGELOG.md b/vscode-client/CHANGELOG.md index e9e54c592..aeb4d712f 100644 --- a/vscode-client/CHANGELOG.md +++ b/vscode-client/CHANGELOG.md @@ -1,5 +1,8 @@ # Bash IDE +## 1.43.1 +- Properly dispose client. + ## 1.43.0 - Upgrade language server to 5.4.2 (treesitter upgrade). diff --git a/vscode-client/package.json b/vscode-client/package.json index aa8eb1a3b..fd3a934f6 100644 --- a/vscode-client/package.json +++ b/vscode-client/package.json @@ -4,7 +4,7 @@ "description": "A language server for Bash", "author": "Mads Hartmann", "license": "MIT", - "version": "1.43.0", + "version": "1.43.1", "publisher": "mads-hartmann", "repository": { "type": "git",