Add bashly generate --quiet
#109
Conversation
|
|
||
| context "when source files already exist" do | ||
| before do | ||
| expect { subject.run %w[generate --quiet] } #.to output_nothing |
There was a problem hiding this comment.
The rspec_approvals gem doesn't seem to like empty output, which is awkward in this situation. Since you're the creator of both gems I figured you'd have an idea about what to do here.
There was a problem hiding this comment.
Well, it is by design. An empty output can be tested with .to be_empty and there is no need for an approval matcher. So, it is usually a mistake when you use any of the approval matches, with an empty output. But don't worry about it, I will take a deeper look in the spec and fix accordingly.
|
Excellent idea, and a great implementation - thanks for both. I will review the PR locally, and probably make a few adjustments, and fix whatever problem there is with
Why is that? Shouldn't |
2 participants
For development, I have a script that wraps my command and runs
bashly generatebefore each invocation to pick up any changes I've made. In this situation, the output of the generation is extraneous and distracting, so I've added a--quietswitch which hides all the boring changes (though it does still printcreated #{file}after generating any new files).